tools: extract Nix dependency lists to separate files #60495
Merged
+73
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should improve the readability, as well as the UX of cherry-picking what dependency the user wants in their env.
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
aduh95
added
dont-land-on-v20.x
JakobJingleheimer
approved these changes
Nov 8, 2025
Member
JakobJingleheimer
left a comment
JakobJingleheimer
left a comment
There was a problem hiding this comment.
I don't know nix (so I can't comment on the syntax etc), but I don't see anything obviously wrong and this is cleaner.
Is there any kind of test to verify that it works?
Contributor
Author
There's the CI: https://github.com/nodejs/node/actions/runs/18940662484/job/54078490316?pr=60495 |
aduh95
added
author ready
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in c94047d |
aduh95
added a commit
that referenced
this pull request
Nov 10, 2025
This should improve the readability, as well as the UX of cherry-picking what dependency the user wants in their env. PR-URL: #60495 Reviewed-By: Jacob Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should improve the readability, as well as the UX of cherry-picking what dependency the user wants in their env.